Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API for starting the nREPL server #28

Closed
PEZ opened this issue May 4, 2022 · 2 comments · Fixed by #29
Closed

API for starting the nREPL server #28

PEZ opened this issue May 4, 2022 · 2 comments · Fixed by #29
Labels
api nrepl

Comments

@PEZ
Copy link
Collaborator

PEZ commented May 4, 2022

I started to add Joyride jack-in to Calva, and realized I want an API call for this instead of executing a command that might change its id later on.

Thinking that the Joyride extension can provide an API function startNReplServer(projectRootUri, callback). The callback function will be called when the server is started with a map/object like {"port": <port> "error": <error-message-or-undefined>}.
@borkdude
Copy link
Collaborator

borkdude commented May 4, 2022

Seems good to me. Could also return a promise which has error handling built-in.

@PEZ
Copy link
Collaborator Author

PEZ commented May 4, 2022

Yes, maybe that is also more in line with other VS Code APIs.

@PEZ PEZ mentioned this issue May 4, 2022
Merged
@PEZ PEZ linked a pull request May 4, 2022 that will close this issue
nRepl server start stop and API #29
Merged
PEZ added a commit that referenced this issue May 4, 2022
@PEZ
Accept the root path a string argument
e7ca496 
Fixes #28
@PEZ PEZ closed this as completed in #29 May 5, 2022
PEZ added a commit that referenced this issue May 5, 2022
@PEZ @borkdude
nRepl server start stop and API (#29)
21c3cb3 
* Rename and refactor nREPL start/stop
  * Make creation and removal of port file more reliable
* Add API for starting nREPL server
  * Make start server return a promise
* Add docs for extension API
* Add some more playground code
* Add `when` clause contexts and getContextValue API

Fixes #28

Co-authored-by: Michiel Borkent <michielborkent@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api nrepl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

nRepl server start stop and API BetterThanTomorrow/joyride
2 participants
@PEZ @borkdude