Pez/vsix+fs testing flakyness #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(We should probably either figure out why we need to do this, or glob the list from the filesystem ourselves. TODO.)
|
@PEZ I'll re-run this a few times to double-check on the flakiness :-D |
borkdude
reviewed
Feb 13, 2023
| branches: | ||
| ignore: /.*/ | ||
| tags: | ||
| only: /^v\d+\.\d+\.\d+-?.*/ |
There was a problem hiding this comment.
Let's see... This is part of the publish-release pipeline and we only want to run this if we're on a version tag. We allow for pre-releases in waiting for semver pre-releases to be supported by the marketplace. Which maybe will never happen.
- Should vsce deal with pre-release version identifiers? microsoft/vscode-vsce#148
- Allow extensions to publish beta releases and users to opt-in to them microsoft/vscode#15756 (comment)
It's copied over from Calva where more of the pre-release publishing is prepared for. We could consider cleaning it away from here.
|
Other than my question: LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a dummy extension to feed the vscode-test launcher when we are testing the extension from the filesystem
Installing extensions and user data in the local VS Code Insiders (not the Machine/global install as before). Should make it safer and more stable to run the tests locally.
Fixes We should test the VSIX package in addition to from the filesystem #154
I have read the developer documentation.
This PR corresponds to an issue with a clear problem statement.
This PR contains a test to prevent against future regressions
I have updated the [Unreleased] section of the CHANGELOG.md file with a link to the addressed issue.