Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update dependencies and README #29

Merged
merged 6 commits into from
Jan 4, 2022
Merged

Conversation

CelticMajora
Copy link
Contributor

📰 Summary of changes

  • Add pub badge to README
  • Update all dependencies to their most recent versions

Reviewers

/domain @Betterment/better_test_reporter-maintainers
/no-platform

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

2 similar comments
@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

LCOV of commit 1248e57 during CI #46

Summary coverage rate:
  lines......: 86.9% (172 of 198 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

⛔ The code coverage is too low. Expected at least 90.

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

1 similar comment
@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

samandmoore
samandmoore previously approved these changes Dec 15, 2021
Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<<domainlgtm

Just gotta figure out why the coverage went down??

@CelticMajora
Copy link
Contributor Author

Think some generated freezed magic under the hood made it so factory constructors that were called in the pass are no longer registering as covered 🤔

@github-actions
Copy link

LCOV of commit 2767dff during CI #47

Summary coverage rate:
  lines......: 23.9% (331 of 1385 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

⛔ The code coverage is too low. Expected at least 90.

@github-actions
Copy link

LCOV of commit b91a50f during CI #48

Summary coverage rate:
  lines......: 86.9% (172 of 198 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

⛔ The code coverage is too low. Expected at least 90.

@github-actions
Copy link

LCOV of commit a5d955a during CI #49

Summary coverage rate:
  lines......: 95.0% (170 of 179 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit ffdb512 during CI #50

Summary coverage rate:
  lines......: 95.0% (170 of 179 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions
Copy link

LCOV of commit d670c57 during CI #51

Summary coverage rate:
  lines......: 94.5% (172 of 182 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@CelticMajora
Copy link
Contributor Author

bump nanda

Still not entirely sure why it started reporting factory constructors in freezed files as valid lines for coverage, but added in ignores to cover them. Only wrapped the factory constructors so that it should be clear to add anything else to these files outside of the ignore block. Will keep digging into the why 🤔

@samandmoore
Copy link
Member

Weird!

@samandmoore
Copy link
Member

<<domainlgtm

@CelticMajora CelticMajora merged commit 7602b24 into main Jan 4, 2022
@CelticMajora CelticMajora deleted the update-deps-and-readme branch January 4, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants