-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependencies and README #29
Conversation
Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review Use the shovel operator to claim, e.g.:
|
2 similar comments
Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review Use the shovel operator to claim, e.g.:
|
Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review Use the shovel operator to claim, e.g.:
|
Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review Use the shovel operator to claim, e.g.:
|
1 similar comment
Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review Use the shovel operator to claim, e.g.:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<<domainlgtm
Just gotta figure out why the coverage went down??
Think some generated freezed magic under the hood made it so factory constructors that were called in the pass are no longer registering as covered 🤔 |
bump nanda Still not entirely sure why it started reporting factory constructors in freezed files as valid lines for coverage, but added in ignores to cover them. Only wrapped the factory constructors so that it should be clear to add anything else to these files outside of the ignore block. Will keep digging into the why 🤔 |
Weird! |
<<domainlgtm |
📰 Summary of changes
Reviewers
/domain @Betterment/better_test_reporter-maintainers
/no-platform