Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add pana verification #35

Merged
merged 1 commit into from
Feb 17, 2022
Merged

chore: Add pana verification #35

merged 1 commit into from
Feb 17, 2022

Conversation

CelticMajora
Copy link
Contributor

📰 Summary of changes

Adds pana score verification. NOTE: currently only verifying that we get a 110 due to the analyzer failures we are seeing in generated files. Will create issue to investigate that.

Reviewers

/domain @Betterment/better_test_reporter-maintainers
/no-platform

@nanda-prbot
Copy link

Needs somebody from @Betterment/better_test_reporter-maintainers to claim domain review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

HOW TO: Claim a Review

@github-actions
Copy link

LCOV of commit 5893022 during CI #67

Summary coverage rate:
  lines......: 95.6% (172 of 180 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Member

@samandmoore samandmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<<domainlgtm

Copy link

@nanda-prbot nanda-prbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! 🍟 🥑 🍔

@CelticMajora CelticMajora merged commit a429541 into main Feb 17, 2022
@CelticMajora CelticMajora deleted the add-pana-verification branch February 17, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants