Ruby 3.2.2 upgrade #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update tests GH workflow
We are sitting on 1.56.4, whereas last time we were on .0. Seems like rubocop-rspec is still in the process of figuring out what to do wrt RSpec/FilePath (rubocop/rubocop-rspec#1723), so this seems appropriate
Rubocop was reporting a naming mismatch between the spec and the classname; turns out spec filenames were correct and we were missing a Betterment module in each of the utils
effron
approved these changes
Sep 29, 2023
|
question: Should we also add |
|
for posterity, we don't need to specify that here because this uses a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/task https://app.asana.com/0/1204779908415024/1205454087538425/f
.ruby-versionrequired_ruby_versionto be>= 3.0in gemspecTargetRubyVersioninrubocop.ymlto be 3.0lmk if you want me to update the version and the changelog (held off because I saw other PR's don't necessarily do this)
@smudge @effron