-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The no-stim protocols have at least air-puff on #42
Comments
This may happen in PROB trials. If these were not PROBE trials then its a bug. If we don't need PUFF in no-stim in PROBE as well, then I need to change the logic. |
Hey!
Yes, no need for probe trials in the no-stim or limited stim protocols..
- Ananth
…On Tue, Jun 4, 2019 at 1:41 PM Dilawar Singh ***@***.***> wrote:
This may happen in PROB trials. If these were not PROBE trials then its a
bug. If we don't need PUFF in no-stim in PROBE as well, then I need to
change the logic.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=ACXXJCYPONEFOBIQJPB7SUDPYYPUNA5CNFSM4HR73A2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW3Y7TI#issuecomment-498569165>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXXJCZVAYVUHEFS36KM6EDPYYPUNANCNFSM4HR73A2A>
.
|
Sorry let me be clearer:
I understand when CS is NONE and there should NOT be any US (puff/tone) played? Is that right? |
@ananthamurthy ping. |
Hey,
Yes, no cs means no puff either.
Additionally, we could have a specific protocol with only puff.
…On Tue, 4 Jun 2019 at 2:46 PM, Dilawar Singh ***@***.***> wrote:
@ananthamurthy <https://github.com/ananthamurthy> ping.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#42?email_source=notifications&email_token=ACXXJC5PYPMDIR4HDHLUFWDPYYXHHA5CNFSM4HR73A2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW36OEI#issuecomment-498591505>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXXJCYOS7CMTOVFEVMON43PYYXHHANCNFSM4HR73A2A>
.
|
I think the new commit on master should fix it. I am leaving this open, needs testing. I'll it close once you confirm that things are fine. |
They are in config.h file.
|
Is there any update on this @ananthamurthy ? Just pinging to refresh the old tickets. |
There were some protocols with no-stim but the air-puff is still turning on at the right time
The text was updated successfully, but these errors were encountered: