Don't recalcuate histogram if not necessary #282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm making great use of this plugin, but if data gets huge (like 32 million datapoints) it becomes much slower.
For example, after the umap is loaded and I circle a cluster it takes like 17 seconds to highlight the clusters.
This is the first PR to improve this. With the proposed changes, the 2dhistogram is not recalculated if the data hasn't changed.
It already reduces the computational time from 17 seconds to like 12 seconds.
Seconds PR follows :-)
Best,
Thorsten