Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents selecting source language that already exists for narrating #1176

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

AnonymousWalker
Copy link
Collaborator

@AnonymousWalker AnonymousWalker commented Aug 5, 2024

This change is Reviewable

@jsarabia
Copy link
Collaborator

jsarabia commented Aug 6, 2024

Let's say a translation team is working with a GL that is working on a translation project, but their source audio isn't finished and so someone is recording a narration.

This PR prevents that. I propose closing this.

Copy link
Collaborator Author

@AnonymousWalker AnonymousWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I made the fix

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Collaborator

@jsarabia jsarabia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved

@jsarabia jsarabia merged commit d88e738 into dev Aug 8, 2024
9 of 10 checks passed
@jsarabia jsarabia deleted the aw-disable-existing-language branch August 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants