Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wk debug signing #1193

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Wk debug signing #1193

merged 7 commits into from
Nov 8, 2024

Conversation

wkelly17
Copy link
Contributor

@wkelly17 wkelly17 commented Nov 8, 2024

This change is Reviewable

wkelly17 and others added 6 commits November 7, 2024 15:33
)

The issue here is that we are checking based on the label and not the formatted label. The label for chapter maker 2 and verse marker 2 is just "2", however, the formatted label is "chapter-marker-2" and "verse-marker-2"
* Protect setting recordedVerses

A crash seems to be connected to a concurrent modification issue

Also clean up in undock

* Update AudioWorkspaceView.kt
@wkelly17 wkelly17 requested a review from jsarabia November 8, 2024 19:20
@jsarabia jsarabia merged commit f7c78bc into dev Nov 8, 2024
9 checks passed
@jsarabia jsarabia deleted the wk-debugSigning branch November 8, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants