-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[client] improve entity details show/hide #1898
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes implement the requested features effectively. The removal of the double-click functionality, the addition of the 'E' key shortcut, and the new behavior for showing entity details on the second click of the same hex are all well-implemented. The code is clean and focused on the required changes. The new KeyBoardKey component is a good addition for visual feedback. Overall, this is a solid implementation of the requested features.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
|
||
protected handleHexSelection(hexCoords: HexPosition) { | ||
const contractHexPosition = new Position({ x: hexCoords.col, y: hexCoords.row }).getContract(); | ||
const position = getWorldPositionForHex(hexCoords); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a comment here to explain the new behavior of showing entity details on the second click of the same hex.
const position = getWorldPositionForHex(hexCoords); | |
const position = getWorldPositionForHex(hexCoords); | |
// If the same hex is clicked again, show entity details |
@@ -93,19 +94,38 @@ export const LeftNavigationModule = () => { | |||
[structureInfo], | |||
); | |||
|
|||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good addition of the key press event listener for the 'E' key. This implements the requirement to show entity details when 'E' is pressed.
size="xl" | ||
onClick={() => setView(view === View.EntityView ? View.None : View.EntityView)} | ||
/> | ||
<KeyBoardKey invertColors={view === View.EntityView} className="absolute top-1 right-1" keyName="E" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition of the KeyBoardKey component to visually indicate the 'E' shortcut for entity details.
… raschel/issue1897
@@ -13,6 +14,7 @@ import { currencyFormat, formatNumber } from "@/ui/utils/utils"; | |||
import { EternumGlobalConfig, ID, ResourcesIds } from "@bibliothecadao/eternum"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EternumGlobalConfig - needs to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #1897