Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click events for SVG Elements #229

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

i-mitra
Copy link

@i-mitra i-mitra commented Jul 19, 2021

Hey Paul,

Before I go ahead and added more flexibilities and features for click events, I thought I'd review with you some of the changes on SVG and SVGBase.

  • SVGBase
    I added couple of methods for us to fetch all elements at a specific location, which can be restricted to only elements with ids. We could move containsCoords into Box as it's more of a helper method for Box.
  • SVG
    Just exposing getElementsAt from base.
  • SVGRenderer
    Rather than fetching for ids, I thought we might as well put them in idToElementMap while creating the render tree. We could change this to getIdToElementMap().put(id, obj). Moreover we can then expose getIdToElementMap().

Let me know what you think.

Ishan

@i-mitra i-mitra marked this pull request as draft July 19, 2021 12:07
@BigBadaboom
Copy link
Owner

Thanks. This looks useful. I'll look through the code as soon as I have a bit of time, and add some comments.

@debugnrebuild
Copy link

debugnrebuild commented Oct 5, 2022

any update on this Merge Request ?

@marcoscortes1 marcoscortes1 linked an issue Apr 2, 2023 that may be closed by this pull request
@BigBadaboom BigBadaboom removed a link to an issue Apr 2, 2023
@asadaltaf583
Copy link

I want to interact with svg layers ie i want to add as many sticker views as layers in svg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants