Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and align to dbt 1.8 syntax #92

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

Bilbottom
Copy link
Owner

@Bilbottom Bilbottom commented Jun 23, 2024

Summary by Sourcery

This pull request upgrades dependencies and aligns the project to dbt 1.8 syntax. It includes renaming test configurations, adding new unit tests, removing outdated test files, and updating project configurations and scripts.

  • Enhancements:
    • Aligned test configurations to dbt 1.8 syntax by renaming 'tests' to 'data_tests' across multiple schema files.
  • Tests:
    • Added new unit tests for various models including 'pl__daily_metrics', 'pl__task_details', 'stg__daily_tracker', 'stg__finances', 'int__transaction_items', 'pl__daily_tracker', 'stg__monzo_transactions', and 'int__transactions'.
    • Removed outdated unit test SQL files from the 'tests/unit' directory.
  • Chores:
    • Updated 'dbt_project.yml' to include new flags for explicit package overrides, model name requirements, and source freshness run project hooks.
    • Removed deprecated dbt unit testing package from 'packages.yml'.
    • Updated 'dbt-commands.sh' to align with new test selection syntax.

Copy link

sourcery-ai bot commented Jun 23, 2024

Reviewer's Guide by Sourcery

This pull request upgrades dependencies and aligns the codebase to dbt 1.8 syntax. The primary changes include renaming 'tests' to 'data_tests' across various schema files, adding new unit tests for multiple models, and removing outdated unit tests and macros. Additionally, configuration settings in 'profiles.yml' and 'dbt_project.yml' have been updated to be compatible with dbt 1.8.

File-Level Changes

Files Changes
billiam_database/models/staging/_schema.yml
billiam_database/seeds/_seeds.yml
billiam_database/models/intermediate/_schema.yml
Renamed 'tests' to 'data_tests' for all columns to align with dbt 1.8 syntax.
billiam_database/models/presentation/tests/test__pl__daily_metrics.yml
billiam_database/models/presentation/tests/test__pl__task_details.yml
billiam_database/models/staging/tests/test__stg__daily_tracker.yml
billiam_database/models/staging/tests/test__stg__finances.yml
billiam_database/models/intermediate/tests/test__int__transaction_items.yml
billiam_database/models/presentation/tests/test__pl__daily_tracker.yml
billiam_database/models/staging/tests/test__stg__monzo_transactions.yml
billiam_database/models/intermediate/tests/test__int__transactions.yml
Added new unit tests for various models.
billiam_database/tests/unit/presentation/pl__daily_metrics.sql
billiam_database/tests/unit/intermediate/int__transaction_items.sql
billiam_database/tests/unit/presentation/pl__task_details.sql
billiam_database/tests/unit/presentation/pl__daily_tracker.sql
billiam_database/tests/unit/staging/stg__daily_tracker.sql
billiam_database/tests/unit/staging/stg__finances.sql
billiam_database/tests/unit/intermediate/int__transactions.sql
billiam_database/tests/unit/staging/stg__monzo_transactions.sql
billiam_database/macros/configs/unit_test.sql
Deleted old unit tests and unit test macro.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Bilbottom - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Bilbottom Bilbottom merged commit b3e6311 into main Jun 23, 2024
2 checks passed
@Bilbottom Bilbottom deleted the upgrade-dependencies branch June 23, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant