-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make executable (but not really) #100
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces several changes across multiple files. The most significant changes include the addition of a summary row in the SQL view, renaming the 'OutlookInput' class to 'Outlook' across the codebase, and adding debug logging to various parts of the application. Additionally, a new section for building the executable using PyInstaller has been added to the README, and argparse has been introduced to handle command-line arguments in the main entry point. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Bilbottom - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the PyInstaller section from the README until it's fully functional to avoid confusion.
- The SQL view modification in reporting.sql is a nice addition, but consider if there's a more efficient way to achieve this result in a single query.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
f02465f
to
c9ffc39
Compare
21229c2
to
d33a56c
Compare
Summary by Sourcery
This pull request introduces command-line argument parsing for debug mode, enhances the SQL view for task rollups, renames classes in Outlook integration modules, and adds detailed logging across the application. Additionally, it updates the README with instructions for building the executable, though this feature is not yet operational.