Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bulk Update): Only Validate Data for Current Item in Loop #612

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

arthurkirkosa
Copy link
Collaborator

@arthurkirkosa arthurkirkosa commented Aug 20, 2024

With large payloads the validation would take between 2 and 5 seconds FOR EACH item in the payload as the validation would run over $request->all()

Copy link

what-the-diff bot commented Aug 20, 2024

PR Summary

This pull request primarily focuses on code formatting and organization in multiple classes across the project and makes updates to some existing tests. Here are the highlights:

  • Code Formatting and Organization

    • Numerous PHP classes across different parts of the application have been edited to improve their readability. This is done by either adding or removing blank lines in specific locations within the classes. This change isn't about adding new features or fixing bugs but is all about making the code easier to read and navigate thus improving overall code maintainability.
  • Method Changes

    • Minor adjustments have been made to methods in several classes to enhance their efficiency. For instance, the FileSystem instantiation has been streamlined in the PublishAuthCommand class and dead space has been cut from methods in classes like RestResponse, AuthorizableModels, etc.
  • Test Improvements & Updates

    • New tests have been introduced in RepositoryAttachControllerTest.php and FieldActionTest.php, key for ensuring the functionality they cover is working as intended.
    • Code in several other test files was also updated to improve their effectiveness.
  • Trait Updates

    • Significant updates have been made to AuthorizesRequests and PerformsRequestValidation traits. These updates could help in enhancing the security and validation mechanisms in our application.
  • Repository & Model Changes

    • Various adjustments have been made to UserRepository.php files and the AvatarFile.php model. These updates might enhance the usage of user profiles across our application.
  • Filter Test Updates

    • The code in filter tests like AdvancedFilterTest.php and MatchableFilterTest.php has been updated, ensuring the filter functionality is tested thoroughly for better application reliability.

@arthurkirkosa arthurkirkosa requested a review from binaryk August 20, 2024 11:07
@binaryk binaryk merged commit 317b4e9 into 9.x Aug 20, 2024
@binaryk binaryk deleted the fix-bulk-update branch August 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants