adds --show-invalid, --stop-on-error to mc/objdump, fixes show-size #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now `bap mc` and `bap objdump` will not stop on errors and continue disassembling unless `--stop-on-error` option is passed. A new option was added, that will print something when an invalid instruction is met. If it not specified invalid instructions are silenced. Fixes options `--show-size` and `--show-kinds` which weren't ouputting anything due to the incorrect defaults.
gitoleg
approved these changes
Nov 22, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
bap mcandbap objdumpwill not stop on errors and continuedisassembling unless
--stop-on-erroroption is passed. A new optionwas added, that will print something when an invalid instruction is
met. If it not specified invalid instructions are silenced.
Fixes options
--show-sizeand--show-kindswhich weren't ouputtinganything due to the incorrect defaults.