disables llvm (< 8.0) disassembler for aarch64 #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LLVM disassembler is broken for aarch64 and segfaults with the NULL-pointer dereference (segmentation fault) on versions below 8.0. There is no clear mitigation (passing a non-NULL pointer for the symbolizer function results in unpredictable behavior) and given that aarch64 is not a first-tier architecture for us yet, we will just disable it for older versions of LLVM.
ivg
requested changes
Mar 17, 2020
lib/bap_llvm/llvm_disasm.cpp
Outdated
| @@ -615,14 +615,30 @@ class llvm_disassembler : public disassembler_interface { | |||
| } | |||
| }; | |||
|
|
|||
|
|
|||
| bool is_error_prone_arch(const char *triple) { | |||
| #if LLVM_VERSION_MAJOR >= 4 && LLVM_VERSION_MAJOR < 8 | |||
There was a problem hiding this comment.
don't use macro here. If anything could be done without a macro, it should be done without it.
ivg
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LLVM disassembler is broken for aarch64 and segfaults with the NULL-pointer dereference (segmentation fault) on versions below 8.0. There is no clear mitigation (passing a non-NULL pointer for the symbolizer function results in unpredictable behavior) and given that aarch64 is not a first-tier architecture for us yet, we will just disable it for older versions of LLVM.
fixes #1081