protects symbolic executor from segfaults when setting memory inputs #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not fail when memory location wasn't explicitly set as symbolic but just register it on the fly.
The memory operation is checking the layering information before any read or write operation to ensure that the address being accessed is properly mapped. It is slow and is linear to the number of layers. However, if the address is already in the values mapping then it means that it was checked and is writable and readable so we can omit the layers check. The latter is only needed when the address is accessed for the first time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not fail when memory location wasn't explicitly set as symbolic but
just register it on the fly.