Upgrades BAP to janestreet v0.16 libraries #1602
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1589
This is here as a placeholder for now in case we want to upgrade to v0.16.0 version ofIt is desirable to keep the version of janestreet libraries (such asbase
,core
,core_kernel
, and other related libraries.base
,core
, andcore_kernel
) as current as possible.Several interfaces have been changed/broken as far as I can see, namely:
X.Set
,X.Map
, andX.Table
have been gutted of various functions that are present inSet
,Map
, andHashtbl
, respectivelySkip
andYield
constructors forSequence.Step.t
each expect an inline record for their arguments.Binable.Of_binable
,Binable.Of_stringable
, andBin_prot.Make_binable
are gone and now have{with,without}_uuid
and other variants. Thewithout_uuid
is marked as "legacy" in the compiler warnings, stating thatwith_uuid
is preferred. I'm leaving it as the former for now as it doesn't require us to change anything else for these functor applications.Caml
is now deprecated in favor ofStdlib
Right now some of the PowerPC unit tests are failing on my end, so I will try to investigate later when I have time (actually, it seems that they are failing without this change. I'm not sure if this is due to a change in newer versions of LLVM or something else).See #1603, can be merged independently.