Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a lot of changes in x86 packed instructions. The main goal is to make a bil code closer to the BIL normal form, i.e. to reduce an amount of an additional code injected during the normalization process as well a time spent for lifting.
As a result,
bap
works better with files that previously took approximately infinite time.Affected instructions are:
pcmp
,pmin
,pmax
;psrl
,psll
,pavg
,xorp
;pcmpistri
Just few numbers to compare:
it was:
it is:
Also, This PR adds few instructions to x86-lifter:
pmaxsb
,pmaxsw
,pmaxuw
,pmaxud
,pmaxsd
and tests for them.