Add IDA Pro brancher. #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify --brancher=ida to utilize IDA's brancher information. Adapted from BinaryAnalysisPlatform#550 for BinaryAnalysisPlatform#861.
abhcs
commented
Sep 5, 2018
abhcs
commented
Sep 5, 2018
plugins/ida/ida_main.ml
Outdated
| @@ -136,13 +136,103 @@ let loader path = | |||
| else code, Memmap.add data mem sec) in | |||
| Project.Input.create arch path ~code ~data | |||
|
|
|||
| let int64_to_word arch = | |||
There was a problem hiding this comment.
A constant width (32) was used in #550: I thought that this was more appropriate.
ivg
requested changes
Sep 5, 2018
There was a problem hiding this comment.
Good work, thanks!
A couple of changes that we need to do before we can merge it:
-
switch to a more efficient data representation (e.g., a hashtable)
-
use word everywhere as soon as possible (it's fine to use int64 as a wire format, but after we receive it, let's use
wordfor everything) -
Do not use
assoc_optit is not available on many versions of compiler (also do not use OCaml stdlib, use Core_kernel instead). -
Do not rely on the default brancher (which is not guaranteed to be default), use
Insn.is_conditionalto determine the kind of the other flow branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow a user to specify the argument '--brancher=ida' to ask BAP to utilize IDA's brancher information. These changes have been adapted from pull request #550 for #861. Pull request #550 was also concerned with kernel symbol recovery; only the changes specific to brancher information from IDA have been used in the current changes. The bap-ida-python repository also needs some complementary changes, which can be viewed here.