fixes the order of arguments in the callsites plugin #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivg
changed the title
ivg
requested changes
Apr 1, 2019
plugins/callsites/callsites_main.ml
Outdated
| (* Note, that we intentionally invert compare for Both and Out | ||
| arguments, since they will be inserted in reverted order later. *) | ||
| let enum_args t = | ||
| let compare x y = match Arg.intent x, Arg.intent y with |
There was a problem hiding this comment.
looks like this order coincides with the intent_order, so it is easier and better just to use it.
ivg
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the callsites plugin was inserting arguments in a such way that dual intent arguments were evaluated after the return arguments. This PR fixes the order, so that the in/our arguments are evaluated before the out arguments. It is also takes extra care and sorts the arguments before inserting, so that we do not rely too much on the order of arguments in the subroutine term.
This PR fixes #740 in which a wrong order of evaluation led to the destruction of a def-use chain.