limits the continuation at the call forkpoint in the promiscuous mode #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug so far when pathes that were taken in the primus promiscuous mode sometimes were far away from the real ones. That was possible because a forked continuation could return and an execution would continue from a forked point. This PR fixes this bug and a forked continuation never returns.
ivg
changed the title
ivg
changed the title
|
Since in 1.6 we do not test promiscuous mode at all (unlike 2.x where we do), I don't see any reason to wait for the tests to pass, so I'm merging this bypassing our CI. |
ivg
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In the promiscuous mode we fork a new machine on each new call, so that if the function doesn't return for any reason, we can continue exploration of the code located after the call.
Problem
The stored continuation wasn't limited and was capturing the whole execution path, including the path in which the function was actually returning. That lead to quite funny false positives in our analysis.
Solution
The continuation is now explicitly delimited with
halt.