fixed failing of - message_response: "accepted" unknown field sending template_message. ignoring any newer fields #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… template_message. ignoring any newer fields.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello and welcome! We are excited to see your first pull request and appreciate your contribution to our project. Our team is reviewing your changes and we will provide feedback as soon as possible. Thank you for taking the time to improve our project and we look forward to working with you!
Bindambc
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
A new field "message_status" is coming in the response of sending template message. and existing jackson converter is failing on finding newer fields. So i have ignored the feature of failing on unknown fields. Other workaround might be adding new field in MessageResponse.java record class, but again things may break if something comeups up again.
Please review and merge it to your main branch. You have developed really beautiful code. great work.
{
"messaging_product": "whatsapp",
"contacts": [
{
"input": "918553224979",
"wa_id": "918553224979"
}
],
"messages": [
{
"id": "wamid.HBgMOTE4NTUzMjI0OTc5FQIAERgSNEIzRDZGNTY2RDBCQkZGQTU1AA==",
"message_status": "accepted"
}
]
}