Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Contact class. Added new enums and methods. Some methods were overridden and the old ones are now deprecated. #69

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

Bindambc
Copy link
Owner

Updated the Contact class. Added new enums and methods. Some methods were overridden and the old ones are now deprecated.

Deprecated:

  • addEmails();
  • addAddresses();
  • addUrls();
  • addPhones();

See full java doc for more details.

@Bindambc Bindambc self-assigned this Mar 27, 2023
@Bindambc Bindambc linked an issue Mar 27, 2023 that may be closed by this pull request
@github-actions github-actions bot added documentation Improvements or additions to documentation java Pull requests that update Java code markdown markdown files tests labels Mar 27, 2023
@Bindambc Bindambc added enhancement New feature or request breaking-change labels Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 76.74% and project coverage change: +9.28 🎉

Comparison is base (11955e1) 66.07% compared to head (4ccb62e) 75.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #69      +/-   ##
============================================
+ Coverage     66.07%   75.35%   +9.28%     
- Complexity      310      388      +78     
============================================
  Files           148      151       +3     
  Lines          1070     1112      +42     
  Branches         11       11              
============================================
+ Hits            707      838     +131     
+ Misses          354      256      -98     
- Partials          9       18       +9     
Impacted Files Coverage Δ
...main/java/com/whatsapp/api/WhatsappApiFactory.java 100.00% <ø> (ø)
...java/com/whatsapp/api/domain/messages/Address.java 100.00% <ø> (+100.00%) ⬆️
.../whatsapp/api/domain/messages/HeaderComponent.java 100.00% <ø> (ø)
...in/java/com/whatsapp/api/domain/messages/Name.java 57.89% <ø> (+57.89%) ⬆️
...ain/java/com/whatsapp/api/domain/messages/Org.java 100.00% <ø> (+100.00%) ⬆️
...n/java/com/whatsapp/api/domain/messages/Phone.java 80.00% <ø> (+80.00%) ⬆️
...ain/java/com/whatsapp/api/domain/messages/Url.java 100.00% <ø> (+100.00%) ⬆️
...java/com/whatsapp/api/domain/templates/Button.java 66.66% <ø> (ø)
...ava/com/whatsapp/api/domain/templates/Example.java 47.36% <ø> (ø)
.../templates/response/MessageTemplateIDResponse.java 0.00% <ø> (ø)
... and 6 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bindambc Bindambc merged commit ade5e1c into main Mar 27, 2023
@Bindambc Bindambc deleted the 67-update-contact-object branch March 27, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change documentation Improvements or additions to documentation enhancement New feature or request java Pull requests that update Java code markdown markdown files tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Contact object.
1 participant