Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched absolute to relative additional radius #382

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

nicogno
Copy link
Contributor

@nicogno nicogno commented Aug 2, 2024

Larger virtual cell radii are currently considered when an interaction force is computed. This PR suggests switching to a virtual radius that is relative to the actual cell radius.
This might affect the demos where cell interaction is involved.

@nicogno nicogno added the minor-fix Small change for fix label Aug 2, 2024
@nicogno nicogno added mechanics Affects agent's mechanical interactions and removed minor-fix Small change for fix labels Aug 2, 2024
@nicogno
Copy link
Contributor Author

nicogno commented Aug 2, 2024

WIP: adapt all the tests

@vasvav
Copy link
Contributor

vasvav commented Aug 4, 2024

I agree with the approach you proposed @nicogno. I'd be in favour however setting the 'additional_radius_scaling' parameter as an input argument to the function. It can be let to take a default value (i.e., 1.03 as you propose in your code changes) yet permit a user to tailor the value to their needs - instead of restricting it to a fixed parameter value, isn't it?

@TobiasDuswald
Copy link
Contributor

The force is a function so it would have to be a member variable together with some appropriate void Set[...](double val) and double Get[...](double val) functions. Optionally one could add this parameter to param.h. Either way, it would be nice if one could easily control these parameter via an interface that does not require rebuilding BDM. 👍

@nicogno
Copy link
Contributor Author

nicogno commented Aug 7, 2024

Adapted tests and made the value adjustable by the user

Copy link

sonarqubecloud bot commented Aug 8, 2024

@TobiasDuswald
Copy link
Contributor

Changes look all good to me. Just wondering, have you checked if/how it affects the demos?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mechanics Affects agent's mechanical interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants