Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add tryparse #241

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

jakobnissen
Copy link
Member

Still WIP

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (3de9d43) 90.52% compared to head (c24e4aa) 90.43%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/longsequences/constructors.jl 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   90.52%   90.43%   -0.09%     
==========================================
  Files          31       31              
  Lines        2395     2416      +21     
==========================================
+ Hits         2168     2185      +17     
- Misses        227      231       +4     
Flag Coverage Δ
unittests 90.43% <91.30%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Still needs to implement tryconvert of biosymbol, then trysetindex! in order
to have tryparse work generically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant