Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove utils introduced in #12 #19

Merged
merged 1 commit into from
May 4, 2016
Merged

remove utils introduced in #12 #19

merged 1 commit into from
May 4, 2016

Conversation

bicycle1885
Copy link
Member

I'd like to propose that removing utility functions introduced in #12: writegz, readgz, and gzopen.
There are some reasons I don't think these are suitable in Libz.jl:

  1. Libz.jl is an interface package for zlib, which doesn't offer these functions.
  2. Accessing a compressed file by its filename is not a standard way: Neither zlib of Python3 nor Zlib of Node.js does not have such interfaces.
  3. These functions are fairly easy to implement; the user can define these things with a few lines of code if necessary.

Any thoughts?

@codecov-io
Copy link

Current coverage is 75.28%

Merging #19 into master will decrease coverage by -3.32% as of 184c925

@@            master     #19   diff @@
======================================
  Files            5       5       
  Stmts          187     178     -9
  Branches         0       0       
  Methods          0       0       
======================================
- Hit            147     134    -13
  Partial          0       0       
- Missed          40      44     +4

Review entire Coverage Diff as of 184c925

Powered by Codecov. Updated on successful CI builds.

@bicycle1885
Copy link
Member Author

I will apply this change before the next release if no objections.

@TransGirlCodes
Copy link
Member

I think these are reasonable arguments, and that this is all good.

@bicycle1885
Copy link
Member Author

Thanks. I will merge this if tests are green.

@bicycle1885
Copy link
Member Author

Environment: JULIAVERSION=julianightlies/bin/winnt/x64/julia-latest-win64.exe hangs on AppVeyor. This sometimes happens, and would be harmless because other tests have passed.

@bicycle1885 bicycle1885 merged commit dc6fa4f into master May 4, 2016
@bicycle1885 bicycle1885 deleted the rm-utils branch May 4, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants