Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Consider env variables in Travis CI settings #735

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

schuhschuh
Copy link
Member

This PR is also used to test the CI builds. These passed for #733 even though a clear compilation error was present in SurfaceCollisions.cc (cf. a8026d2).

@schuhschuh schuhschuh force-pushed the test-ci-build-with-known-compiler-error-in-SurfaceCollisions branch from 237b09b to b574fd8 Compare September 21, 2020 12:18
@schuhschuh
Copy link
Member Author

Actually, the error was not picked up because it is in an mirtkAssert statement which is discarded in Release mode.

@schuhschuh schuhschuh force-pushed the test-ci-build-with-known-compiler-error-in-SurfaceCollisions branch from 0e5b44c to bfc232e Compare September 21, 2020 14:58
@schuhschuh schuhschuh changed the title ci: Consider env variables in Travis CI settings WIP: Consider env variables in Travis CI settings Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant