Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Lightning 2.0.0 >= #54

Merged
merged 11 commits into from
Jun 15, 2023
Merged

Support Lightning 2.0.0 >= #54

merged 11 commits into from
Jun 15, 2023

Conversation

SagiPolaczek
Copy link
Collaborator

@SagiPolaczek SagiPolaczek commented Jun 12, 2023 •
edited
Loading

✅

Same as Fuse's

IMPORTANT

Couldn't fix the following unit-test:

/dccstor/mm_hcls/usr/sagi/git_repos/fuse-drug/fusedrug_examples/tests/test_bimodal_mca.py BimodalMCATestCase.test_runner

Got some weird issue where it just crashes in the end of the multi-processing part: (without multi-processing it works OK !)

column names used=['molecule_sequence', 'molecule_id'] - if it does not look like column names make sure that the following args are properly set: first_row_is_columns_names, columns_names
allow_access_by_id is enabled, building in-memory offset map (num_workers=128)
multiprocess pool created with 128 workers.
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 441/441 [00:35<00:00, 12.55it/s]
[rank: 0] Received SIGTERM: 15████████████████████████████████████████████████████████████████████████████████████████▍| 439/441 [00:35<00:00, 14.29it/s]
[rank: 0] Received SIGTERM: 15
[rank: 0] Received SIGTERM: 15
[rank: 0] Received SIGTERM: 15
[rank: 0] Received SIGTERM: 15
[rank: 0] Received SIGTERM: 15
[rank: 0] Received SIGTERM: 15
.
.
.

I spent few hours to try to fix it but didn't succeed. The closest thing I found was this Lightning x PyData issue.

@SagiPolaczek SagiPolaczek marked this pull request as draft June 12, 2023 07:23
@SagiPolaczek SagiPolaczek marked this pull request as ready for review June 14, 2023 18:32
mosheraboh
mosheraboh reviewed Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@mosheraboh mosheraboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sagi!
minors inline

fusedrug_examples/tests/test_bimodal_mca.py Outdated
@@ -50,6 +50,7 @@ def test_data_and_model(self) -> None:
# forward pass
lightning_module.forward(smiles, proteins)

@unittest.skip("Doesn't support Lightning >= 2.0.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the weird issue?
Can you open an issue and a trello card for alex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is.
Will do now 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

fusedrug_examples/interaction/drug_target/affinity_prediction/cat_dti/config.yaml Outdated
@@ -39,7 +39,7 @@ params:
num_epochs: 100
accelerator: gpu
num_devices: 1
strategy: null #"auto" for pl 2.0.0
strategy: "auto" # null for Lightning<2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just remove this line? - works for both

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :) done.

@SagiPolaczek SagiPolaczek mentioned this pull request Jun 15, 2023
Open
@SagiPolaczek SagiPolaczek merged commit edec9d0 into main Jun 15, 2023
@SagiPolaczek SagiPolaczek deleted the sagi/pl_2.0 branch June 15, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosheraboh mosheraboh mosheraboh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SagiPolaczek @mosheraboh