fix: properly cleanup network replies on destruction

Bionus · Nov 14, 2022 · 09c6edf · 09c6edf
1 parent b49e35d
commit 09c6edf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/lib/src/network/network-reply.cpp b/src/lib/src/network/network-reply.cpp
@@ -15,6 +15,15 @@ NetworkReply::NetworkReply(QNetworkRequest request, QByteArray data, CustomNetwo
 	init();
 }
 
+NetworkReply::~NetworkReply()
+{
+	abort();
+
+	m_reply->deleteLater();
+	m_reply = nullptr;
+}
+
+
 void NetworkReply::init()
 {
 	timer.setSingleShot(true);

diff --git a/src/lib/src/network/network-reply.h b/src/lib/src/network/network-reply.h
@@ -21,6 +21,8 @@ class NetworkReply : public QObject
 
 		NetworkReply(QNetworkRequest request, CustomNetworkAccessManager *manager, QObject *parent = nullptr);
 		NetworkReply(QNetworkRequest request, QByteArray data, CustomNetworkAccessManager *manager, QObject *parent = nullptr);
+		~NetworkReply();
+
 		QUrl url() const;
 		QVariant attribute(QNetworkRequest::Attribute code) const;
 		QByteArray readAll();