chore: fix a few leaks

Bionus · Jan 7, 2023 · d63cb50 · d63cb50
1 parent a47afc2
commit d63cb50
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/gui/src/batch/batch-window.cpp b/src/gui/src/batch/batch-window.cpp
@@ -55,6 +55,9 @@ BatchWindow::~BatchWindow()
 {
 	delete ui;
 
+	delete m_time;
+	delete m_start;
+
 	#ifdef Q_OS_WIN
 		m_taskBarButton->deleteLater();
 		m_taskBarProgress->deleteLater();

diff --git a/src/lib/src/models/profile.cpp b/src/lib/src/models/profile.cpp
@@ -218,6 +218,7 @@ Profile::~Profile()
 
 	qDeleteAll(m_sources);
 	delete m_commands;
+	delete m_md5s;
 	delete m_monitorManager;
 	delete m_downloadQueryManager;
 	delete m_urlDownloaderManager;

diff --git a/src/lib/src/models/url-downloader/url-downloader-manager.cpp b/src/lib/src/models/url-downloader/url-downloader-manager.cpp
@@ -22,11 +22,7 @@ UrlDownloaderManager::UrlDownloaderManager(const ReadWritePath &root, QObject *p
 
 UrlDownloaderManager::~UrlDownloaderManager()
 {
-	for (auto *downloader : m_downloaders) {
-		downloader->deleteLater();
-	}
-	m_downloaders.clear();
-
+	qDeleteAll(m_downloaders);
 	m_engine->deleteLater();
 }
 

diff --git a/src/lib/src/models/url-downloader/url-downloader-manager.h b/src/lib/src/models/url-downloader/url-downloader-manager.h
@@ -16,7 +16,7 @@ class UrlDownloaderManager : public QObject
 
 	public:
 		explicit UrlDownloaderManager(const ReadWritePath &root, QObject *parent = nullptr);
-		~UrlDownloaderManager();
+		~UrlDownloaderManager() override;
 
 		bool load(const QString &file);
 		UrlDownloader *canDownload(const QUrl &url) const;