Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IDs instead of dates for the favorites "last viewed" information #1058

Closed
Bionus opened this issue Sep 7, 2017 · 4 comments
Closed

Use IDs instead of dates for the favorites "last viewed" information #1058

Bionus opened this issue Sep 7, 2017 · 4 comments
Assignees
Milestone

Comments

@Bionus
Copy link
Owner

Bionus commented Sep 7, 2017

Since IDs are chronologically ordered (unless some very big problem with your source), instead of storing the last time the favorites where viewed, Grabber could store the highest ID of each source.

This could help supporting sources that do not provide date information.

Follows #1041.

@Bionus
Copy link
Owner Author

Bionus commented Feb 23, 2019

Removed from 7.0.0 as the cost is much higher than planned.

Will be done at the same time as the favorite re-work.

@FichteFoll
Copy link

FichteFoll commented May 21, 2020

I think this strongly relates to #1416.
What are the planned changes for the favorites feature? I've only started using it today, because documentation on it was rather sparse. After having used it for a bit, they feel more like a "follow" list, though I guess that's just a naming thing.

Regardless, while the favorites feature was something I was looking for, it certainly has a couple rough edges. For example, when there is a huge-ish list or even just 400 images total, it may take a while to browse through all of them. From how the feature currently works, it makes sense to start with the oldest image and then move backwards as you adjust the "Last view" setting to when the last image you viewed has been added. However, there is no shortcut or context menu on an image to say "please mark this as the last viewed image", so you have to fetch the image's upload time and insert it into the favorite setting manually.

I'm not sure if commenting on this issue is correct or whether I should open a new one.

By the way, what does the "Note" field do or represent? It's not intuitive and not documented.

@Bionus
Copy link
Owner Author

Bionus commented May 21, 2020

I think this strongly relates to #1416.

I don't think so, as this issue is purely a technical one to avoid a potential bug on a few sources, while the one you mention is about quality of life improvements / new features around favorites.

Regardless, while the favorites feature was something I was looking for, it certainly has a couple rough edges. For example, when there is a huge-ish list or even just 400 images total, it may take a while to browse through all of them. From how the feature currently works, it makes sense to start with the oldest image and then move backwards as you adjust the "Last view" setting to when the last image you viewed has been added. However, there is no shortcut or context menu on an image to say "please mark this as the last viewed image", so you have to fetch the image's upload time and insert it into the favorite setting manually.

I'm not sure if commenting on this issue is correct or whether I should open a new one.

Your suggestion indeed makes sense, however I suggest opening another issue as one issue should only be about a single thing. Otherwise your suggestion might be lost once the initial subject of this issue is resolved.

By the way, what does the "Note" field do or represent? It's not intuitive and not documented.

It's a value from 0 to 100 that you can use for sorting.
Can be useful to sort your favorites in whatever way you want.

@FichteFoll
Copy link

FichteFoll commented May 22, 2020

I don't think so, as this issue is purely a technical one to avoid a potential bug on a few sources, while the one you mention is about quality of life improvements / new features around favorites.

I think you're right. This issue here (#1058) only tangentially relates to my issue with the "use this entry as the base for a filter" feature, which I copied to #1970.

It's only my other broader problem (#1971) that would be solved by #1416.

@Bionus Bionus added this to the 7.4.0 milestone Jun 1, 2020
@Bionus Bionus modified the milestones: 7.13.0, 7.12.0 May 12, 2024
@Bionus Bionus closed this as completed in bc5c833 May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants