Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Suggestions] MD5 list storage and tools #1439

Closed
brazenvoid opened this issue Sep 30, 2018 · 3 comments
Closed

[Bug/Suggestions] MD5 list storage and tools #1439

brazenvoid opened this issue Sep 30, 2018 · 3 comments
Assignees
Milestone

Comments

@brazenvoid
Copy link

brazenvoid commented Sep 30, 2018

Context

So I have a filtered folder to store the actual collection from the downloaded files. Also separate folders for animated files.

Since a recent update, the MD5 list in storage appears to get updated in the destruction phase of the program and not when the image is downloaded successfully. Because the program crashing is a regular thing for me, this becomes a flaw which otherwise would be an optimization to reduce writes to the disk and avoid the latency penalty. Many times nearly a 1000 images don't get included. Necessitating me to run the tool after each crash.

Suggestions/Fixes

  • Add recursive search to md5 list fixer and maybe to the rename tool as an option.
  • Make it so that the md5 storage occurs on each file download. Perhaps this can be added as a setting to preserve functionality for future stabler versions.
  • Make it so that the md5 fixer tool does not make the program go unresponsive when "Force MD5 calculation" is enabled. Usually the UI gets stuck at ~10% progress bar progress, and resumes when everything is done.
@Bionus
Copy link
Owner

Bionus commented Sep 30, 2018

Add recursive search to md5 list fixer and maybe to the rename tool as an option.

AFAIK, the tool is recursive. However, if you use "get md5 in filename", every file has to match the provided filename (including the directory path), so maybe not all of your files match?

@brazenvoid
Copy link
Author

Add recursive search to md5 list fixer and maybe to the rename tool as an option.

AFAIK, the tool is recursive. However, if you use "get md5 in filename", every file has to match the provided filename (including the directory path), so maybe not all of your files match?

I never use that. It is always set to "Force MD5 calculation"

@brazenvoid
Copy link
Author

It is quite fine, if it does work recursively, it was more of a question. The other two are the actual problems.

@Bionus Bionus self-assigned this Nov 2, 2018
@Bionus Bionus added this to the v6.1.0 milestone Nov 2, 2018
@Bionus Bionus closed this as completed in 8f9bd69 Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants