-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcuts to go to next/previous/first/last page #1983
Comments
Well I made it a few days ago, so hopefully it is 😱 So indeed there are currently no shortcuts for page navigation.
Do you mean Ctrl+Page Up & co? I see you mention Ctrl in only one of those shortcuts. And given the results view has scrolling, binding directly the Page Up & Down will result in weird behavior if no other key is added. |
I didn't think of this. If page up/down aren't free, then things become a bit more complicated because ctrl+pageup/down are already used for tab navigation (and rightfully so). I also didn't think about endless scrolling, in which case page navigation should probably be disabled?
I suggested Ctrl for Home/End because those actions are descructive in that you lose the page number you were previously at and shouldn't be available so easily, whereas going a single page in either direction is reversible by going in the opposite direction. While we're at it, what about an "active" state in image results view that can be navigated using the arrow keys, selects it for download with Space and opens the image view with Enter? Separate issue? |
Haven't thought about tab navigation but indeed.
Indeed a good idea, but also a new issue yeah, especially given the work it might require for up/down arrows with the way the thing is currently done. But an interesting idea that I'd be interested in implementing if there's demand. |
SGTM. |
Is your feature request related to a problem? Please describe
Assuming https://bionus.github.io/imgbrd-grabber/docs/shortcuts.html is complete, there are currently no bindings to navigate search result pages with the keyboard.
Describe the solution you'd like
Page Up/Down and Ctrl+Home/End seem like obvious choices.
Describe alternatives you've considered
Binding "Escape" in the favorites results view to the "Back" button below would also seem natural (to me).
The text was updated successfully, but these errors were encountered: