Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text isn't translated #2705

Closed
adem4ik opened this issue Jun 7, 2022 · 9 comments
Closed

Some text isn't translated #2705

adem4ik opened this issue Jun 7, 2022 · 9 comments
Assignees
Milestone

Comments

@adem4ik
Copy link
Contributor

adem4ik commented Jun 7, 2022

Bug description

Russian and French are fully translated on crowdin. But there are a few untranslated places in both languages.

Steps to reproduce

Here is the list:

  1. Image window - buttons and their popups
    image
  2. Main window - Search (or new tab) - "Ok" button near the search field
    image
  3. Options - Interface - Main Window - Shortcuts
    image
  4. Options - Interface - Image Window - Buttons
    image
  5. Options - Backup - Restore a backup
    image
  6. Image window - Error loading the image. (it is translated on crowdin 6 months ago)
    image
  7. Check "Merge results" in the main window - Activate a few sources - Search -> Multiple sources (it is not presented on crowdin)
    image

Expected behavior

Full translation.

Context

N/A

Screenshots

See above.

System information

  • OS: Windows 10
  • Grabber version: 7.9.0

Additional context

Some of this text is presented on crowdin, some isn't.

@Bionus Bionus added this to the 7.9.1 milestone Jun 8, 2022
@Bionus Bionus self-assigned this Jun 8, 2022
@Bionus
Copy link
Owner

Bionus commented Jun 8, 2022

I will have a look at the other points, but for the second one, the "Ok" button is just translated as "Ok" currently in the Russian translation. You can see that by searching "O&k" in Crowdin (the & is for mnemonics, so Alt+K works).

EDIT: points 3 and 5 should be solved by 78b4364.

@adem4ik
Copy link
Contributor Author

adem4ik commented Jun 9, 2022

I will have a look at the other points, but for the second one, the "Ok" button is just translated as "Ok" currently in the Russian translation. You can see that by searching "O&k" in Crowdin (the & is for mnemonics, so Alt+K works).

Oh, thank you!

@adem4ik
Copy link
Contributor Author

adem4ik commented Jun 15, 2022

I've added point 6 to the starting post.

@adem4ik
Copy link
Contributor Author

adem4ik commented Jun 24, 2022

@Bionus I've added point 7. Let me know if this workflow isn't fine for you. I can make separate issues if you need.

@Bionus
Copy link
Owner

Bionus commented Jun 25, 2022

@adem4ik it's totally fine with me either way 👌 Given each point is quite small it's fine to do it this way
Thank you for doing such in-depth proofing. I admit I'm using the program in English so it's easy to miss some translations 😓

@Bionus
Copy link
Owner

Bionus commented Jul 14, 2022

Now all points should be solved in nightly, is that correct?

@adem4ik
Copy link
Contributor Author

adem4ik commented Jul 14, 2022

Checked on (aeecbc7):

  1. Buttons - partially, mb it needs translation update/sync:
    image
    Their popups aren't translated at all & not presented on crowdin:
    image

  2. Fixed

  3. Fixed

  4. Fixed

  5. Fixed

  6. Fixed

  7. Fixed

@adem4ik
Copy link
Contributor Author

adem4ik commented Jul 14, 2022

Everything is translated now in e95197c
image

@Bionus Bionus closed this as completed in 60597ff Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@Bionus @adem4ik and others