Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra data/text appended after file type extension [rule34hentai.net] #3084

Closed
Ravannos opened this issue Jan 19, 2024 · 2 comments
Closed
Assignees
Labels
bug reproduced This issue was reproduced by the assignee. source
Milestone

Comments

@Ravannos
Copy link

When trying to download from rule34hentai.net (under type Shimmie while using a US VPN connection), any file type that is not a video type (gif, jpg, png and the like) will have additional data appended after the file type extension.

For example, when using the naming system like so: " %artist%/%position%-%date%-%md5%.%ext% "; the filename of the downloaded image becomes " 1-01-18-2024 20.02-aba1e603c89e5ad8fa68ec14e8cdd344.jpg data-width= 3000 data-height= 2800 data-mime= image jpeg "

Looking closer at the url of rule34hentai.net, the same appended text data is present in the url, also appended after the file type. Grabber is likely pulling this part of the url.

Steps to reproduce

  1. Add rule34hentai.net under the type Shimmie
  2. Connect to a US VPN connection
  3. Download a non-video file
  4. Downloaded file will be have the unwanted appended text

Expected behavior
The downloaded file's name should not have "data-width= 3000 data-height= 2800 data-mime= image jpeg" appended at its end

Context
main.log & settings.ini:
main.log-settings.ini_2024-1.zip
.igl:
rule34hentai.net_log.zip

Screenshots
grabber-rule34hentai filename bug

System information

  • OS: Windows 10
  • Grabber version: 7.11.2
@Ravannos Ravannos added the bug label Jan 19, 2024
@Bionus Bionus self-assigned this Jan 20, 2024
@Bionus Bionus added source reproduced This issue was reproduced by the assignee. labels Jan 20, 2024
@Bionus Bionus added this to the 7.12.0 milestone Jan 20, 2024
@Bionus
Copy link
Owner

Bionus commented Jan 20, 2024

I could indeed reproduce the issue. Seems like the regex for parsing image URLs on Shimmie's detail page didn't properly stop at the double quote in the image tag and kept going, grabbing unnecessary stuff.

I just pushed a fix, thanks for the report 👍

@Ravannos
Copy link
Author

I'd also like to report here for anyone else looking into it that manually editing Shimmie's model.js with the provided edit works wonderfully. Just remember to remove and re-add rule34hentai.net to make it stick.

Much obliged boss man. Thanks for your kind help.

@Bionus Bionus modified the milestones: 7.13.0, 7.12.0 May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug reproduced This issue was reproduced by the assignee. source
Projects
None yet
Development

No branches or pull requests

2 participants