Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dependencies. #2473

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Added dependencies. #2473

merged 1 commit into from
Sep 23, 2021

Conversation

Penguin-Guru
Copy link
Contributor

QtNetworkAuth is a new dependency added within the past few versions of Grabber or reorganisation of Gentoo packages. I noticed that something on my system had already pulled in qtnetwork-- I have not tested to confirm that it is required, but it seems very likely.

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2473 (3b79a16) into develop (a2fbfee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2473   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files          416     416           
  Lines        17584   17584           
=======================================
  Misses       17584   17584           

@Penguin-Guru
Copy link
Contributor Author

There is a prompt when installing with QtNetwork (or presumably other packages) already installed on the system as dependencies for other programs-- "Would you like to add these packages to your world favorites?" This can be suppressed with the "--oneshot" flag, but I believe that might confuse some maintenance operations (see warning in emerge man page). My current opinion is that the prompt during install is not a significant nuisance but there might be a better solution I'm not aware of.

@Bionus Bionus merged commit e7a9baa into Bionus:develop Sep 23, 2021
@Bionus
Copy link
Owner

Bionus commented Sep 23, 2021

LGTM! 🚀

There is a prompt when installing with QtNetwork (or presumably other packages) already installed on the system as dependencies for other programs-- "Would you like to add these packages to your world favorites?" This can be suppressed with the "--oneshot" flag, but I believe that might confuse some maintenance operations (see warning in emerge man page). My current opinion is that the prompt during install is not a significant nuisance but there might be a better solution I'm not aware of.

I think this could also apply to the other packages, so it makes sense to leave it as-is in this review 👍

@Penguin-Guru Penguin-Guru deleted the Dependencies branch September 24, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants