Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.iss #3252

Closed
wants to merge 4 commits into from
Closed

Update setup.iss #3252

wants to merge 4 commits into from

Conversation

ProtagNeptune
Copy link

@ProtagNeptune
Copy link
Author

ProtagNeptune commented Jul 23, 2024

I'm confused by that:

Because scripts/windows-setup/setup.iss has .js files listed, not .ts?
So I switched .ts to .js for the files I added but I'm unsure if this is correct.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.63%. Comparing base (eac529a) to head (4c024c8).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #3252    +/-   ##
=========================================
  Coverage    32.63%   32.63%            
=========================================
  Files          384      384            
  Lines        22373    22373            
  Branches      3531     3532     +1     
=========================================
  Hits          7301     7301            
+ Misses       15071    14955   -116     
- Partials         1      117   +116     

@ProtagNeptune
Copy link
Author

Those sources aren't supposed to be included in any release in the first place 🤔
I'll see to remove them from the ZIP release. I'll have to double check if "Hentai Cosplays" is legit and see to include it in the EXE.

Originally posted by @Bionus in #3250 (comment)

@ProtagNeptune ProtagNeptune deleted the patch-1 branch July 24, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant