[MIRROR] [NO GBP] Fixes action_type on clothing to be a list on two items that where static #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… where static (#82075) ## About The Pull Request This changes the action_types on the face scarf from being a static datum to being a list. This is a bug I noticed while working on a PR downstream where i was attempting to add an action to a set of items and this caused a miss-matched type CI error. This realistically shouldn't be the case as everything else on the code base that uses action_types is also a list. So for consistency sake and to remove bugs this will fix the var to be a list instead of static. ## Why It's Good For The Game Less bugs, more consistency with variables. ## Changelog I don't really think this needs a change log, not really player noticeable or player facing. The relative impact on players is minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
https://api.github.com/repos/tgstation/tgstation/pulls/82075About The Pull Request
This changes the action_types on the face scarf from being a static datum to being a list. This is a bug I noticed while working on a PR downstream where i was attempting to add an action to a set of items and this caused a miss-matched type CI error. This realistically shouldn't be the case as everything else on the code base that uses action_types is also a list. So for consistency sake and to remove bugs this will fix the var to be a list instead of static.
Why It's Good For The Game
Less bugs, more consistency with variables.
Changelog
I don't really think this needs a change log, not really player noticeable or player facing. The relative impact on players is minor