dex - poolswap
#216
Merged
dex - poolswap
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 5bba40f and detected 0 issues on this pull request. View more on Code Climate. |
Missing Translations ReportThe following translations are missing for this pull request. View Full Report{
"zh-Hans": {
"missingCount": 54,
"labels": {
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE",
"Transactions"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"'From'} onMaxPress={async (amount)",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/SendScreen": [
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 54
},
"zh-Hant": {
"missingCount": 53,
"labels": {
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"'From'} onMaxPress={async (amount)",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/SendScreen": [
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 54
},
"de": {
"missingCount": 53,
"labels": {
"screens/WalletOnboarding": [
"No wallets"
],
"screens/WalletNavigator": [
"Wallets",
"Create Mnemonic Phrase",
"Verify Mnemonic Phrase",
"Restore Mnemonic Wallet"
],
"screens/LoadingScreen": [
"Loading"
],
"screens/TransactionDetailScreen": [
"tx.desc)",
"tx.amount)",
"`${tx.block}`)",
"tx.txid"
],
"screens/TransactionsScreen": [
"desc",
"block",
"LOAD MORE"
],
"screens/TransactionsDetailScreen": [
"Transaction"
],
"screens/CommunityScreen": [
"Connect with the community:",
"DeFiChain is a community-driven and open project.",
"The DeFiChain Foundation does not provide direct support.",
"title",
"Community"
],
"wallet/settings": [
"key",
"EXIT WALLET"
],
"screens/SettingsNavigator": [
"Settings"
],
"screens/PoolSwapScreen": [
"'From'} onMaxPress={async (amount)",
"To",
"SWAP",
"Enter an amount",
"Balance: ",
"MAX",
"Price",
"Estimated to receive",
"Minimum to receive",
"Liquidity provider fee"
],
"app/DexScreen": [
"section.key"
],
"screens/DexScreen": [
"SWAP",
"Decentralized Exchange"
],
"screens/TokenDetailScreen": [
"AMOUNT BALANCE",
"AVAILABLE OPTIONS",
"Send to other wallet",
"Receive",
"Convert"
],
"screens/SendScreen": [
"SEND",
"TO ADDRESS",
"Enter an address",
"Enter an amount",
"Balance: ",
"MAX",
"Wallet Send"
],
"screens/ReceiveScreen": [
"Use this address to receive DFI or any DST",
"Copy",
"Wallet Receive"
],
"screens/BalancesScreen": [
"BALANCE DETAILS",
"props.title",
"Wallet Balances"
]
},
"totalCount": 54
}
} |
|
✔️ Deploy Preview for defi-wallet ready! 🔨 Explore the source changes: 5bba40f 🔍 Inspect the deploy log: https://app.netlify.com/sites/defi-wallet/deploys/60e5087d87d14b0007f89d3f 😎 Browse the preview: https://deploy-preview-216--defi-wallet.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 42.47% 45.54% +3.06%
==========================================
Files 67 68 +1
Lines 784 830 +46
Branches 82 90 +8
==========================================
+ Hits 333 378 +45
- Misses 451 452 +1
Continue to review full report at Codecov.
|
|
Build preview for DeFi Wallet is ready! Built with commit dfa5536 https://expo.io/@defichain/wallet?release-channel=pr-preview-216 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
thedoublejay
commented
Jul 6, 2021
fuxingloh
requested changes
Jul 6, 2021
app/screens/AppNavigator/screens/Dex/PoolSwap/PoolSwapScreen.tsx
Outdated
Show resolved
Hide resolved
fuxingloh
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
Initial UI design for Pool Swap
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes #146
Additional comments?: