Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force termination after timeout #6

Closed
anderseknert opened this issue Apr 15, 2020 · 0 comments · Fixed by #7
Closed

Force termination after timeout #6

anderseknert opened this issue Apr 15, 2020 · 0 comments · Fixed by #7

Comments

@anderseknert
Copy link
Contributor

We've seen a few reports on kubectl-login not terminating properly and causing high CPU usage after long time of running in the background. Since the program is meant to exit immediately after login, having it remain in the background is clearly a bug, and we should just terminate after a fixed timout of, say 10 minutes.
anderseknert added a commit that referenced this issue May 29, 2020
@anderseknert
Force exit on timeout.
a39b62c 
- Force exit after 10 minutes of (in)activity in order to avoid staying in the background forever on idle as some people reported.
- Add a sleep on the main loop to avoid hogging CPU while waiting for token.
- Fix linter warnings about the use of fmt.Print(fmt.Sprint(..))

Closes #6.
@anderseknert anderseknert mentioned this issue May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force exit on timeout Bisnode/kubectl-login
1 participant
@anderseknert