Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: oracle codebase issue fixed #24

Merged
merged 5 commits into from
Nov 25, 2022
Merged

feat: oracle codebase issue fixed #24

merged 5 commits into from
Nov 25, 2022

Conversation

zadahmed
Copy link
Contributor

No description provided.

@martinkersner
Copy link
Member

@zadahmed There is a conflict in package.json. Can you please look into it?

@zadahmed
Copy link
Contributor Author

@martinkersner Conflicts fixed!

martinkersner
martinkersner approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is just one issue with variable overshadowing. This might later become larger problem so I think we should fix it.

contracts/src/v0.1/Oracle.sol Outdated Show resolved Hide resolved
contracts/src/v0.1/Oracle.sol Outdated Show resolved Hide resolved
@zadahmed
Copy link
Contributor Author

Overshadow issues fixed

@martinkersner
Copy link
Member

@zadahmed Great job! Let's merge it!

@zadahmed zadahmed merged commit 2572cdf into master Nov 25, 2022
@martinkersner martinkersner deleted the i-9/feat/oraclemaster branch November 26, 2022 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zadahmed @martinkersner