Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to insert and update with empty value in cli kv #258

Merged
merged 4 commits into from
Feb 9, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Feb 9, 2023

Description

This PR adds feature for cli kv. Previously, it was not possible to set value of key-value pair as an empty string. After merging this request, it will be possible.

Fixes #252

When using CLI, you can simply omit the --value parameter. When using insertMany, you can define value as an empty string.

insert

yarn cli kv insert --key [chain] --chain[chain]

update

yarn cli kv update --key [chain] --chain[chain]

insertMany

Example of settings.json file with a key-pair value where value is an empty string.

{
  "EMPTY_FIELD": ""
}
yarn cli kv insertMany --file-path [file-path] --chain [chain]

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this Feb 9, 2023
@martinkersner martinkersner linked an issue Feb 9, 2023 that may be closed by this pull request
@martinkersner martinkersner marked this pull request as ready for review February 9, 2023 05:22
@martinkersner martinkersner merged commit 7767eb6 into master Feb 9, 2023
@martinkersner martinkersner deleted the i-252/feat/allow-to-set-empty-in-kv branch February 9, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set empty value in cli kv
1 participant