Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add request response docker compose file #263

Merged
merged 2 commits into from
Feb 9, 2023
Merged

add request response docker compose file #263

merged 2 commits into from
Feb 9, 2023

Conversation

jo-bisonai
Copy link
Member

@jo-bisonai jo-bisonai commented Feb 9, 2023 •
edited
Loading

Description

  • Docker-compose file for request-response

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@jo-bisonai jo-bisonai added this to the 7th KF Meeting - 2 milestone Feb 9, 2023
@jo-bisonai jo-bisonai self-assigned this Feb 9, 2023
@jo-bisonai jo-bisonai linked an issue Feb 9, 2023 that may be closed by this pull request
Request-Response Docker Compose #215
Closed
martinkersner
martinkersner approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

core/docker-compose.request-response.yaml
environment:
- NODE_ENV=production
- ORAKL_DIR=/app/db
- CHAIN=baobab
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be careful with this CHAIN settings, later we will deploy to other chains.

@martinkersner martinkersner merged commit ce6233d into master Feb 9, 2023
@martinkersner martinkersner deleted the i-215/feat/request-response-docker-compose branch February 9, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

Assignees

@jo-bisonai jo-bisonai

Labels
deployment
Projects
None yet
Milestone
7th KF Meeting - 2
Development

Successfully merging this pull request may close these issues.

Request-Response Docker Compose
2 participants
@jo-bisonai @martinkersner