Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add caver-js test #289

Merged
merged 28 commits into from
Feb 21, 2023
Merged

add caver-js test #289

merged 28 commits into from
Feb 21, 2023

Conversation

bayram98
Copy link
Contributor

@bayram98 bayram98 commented Feb 17, 2023 •
edited
Loading

Description

Add caver-js test script to make transaction on Baobab.

  • Caver-js will run when github actions test call.
  • Ethers will run when we call test locally.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.

Deployment

  • Should publish Docker image

@bayram98 bayram98 self-assigned this Feb 17, 2023
@bayram98 bayram98 linked an issue Feb 20, 2023 that may be closed by this pull request
Move to caver-js for reporter #197
Closed
@bayram98 bayram98 marked this pull request as ready for review February 20, 2023 09:44
@KelvinThai
Copy link
Contributor

KelvinThai commented Feb 20, 2023 •
edited
Loading

LGTM!

KelvinThai
KelvinThai approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@KelvinThai KelvinThai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

martinkersner
martinkersner requested changes Feb 20, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the comments. There are quite many, but I think it should be quick to fix.

.github/workflows/core.test+build.yaml Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
core/test/caver-js.test.ts Outdated Show resolved Hide resolved
@bayram98
Copy link
Contributor Author

@martinkersner This PR is ready to review again.

martinkersner
martinkersner approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bayram98 bayram98 merged commit e1556d3 into master Feb 21, 2023
@bayram98 bayram98 deleted the i-197/feat/move-caverjs-for-reporter branch February 21, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KelvinThai KelvinThai KelvinThai approved these changes

@martinkersner martinkersner martinkersner approved these changes

Assignees

@bayram98 bayram98

Labels
off-chain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to caver-js for reporter
3 participants
@bayram98 @KelvinThai @martinkersner