fixed slack interval and new error msg #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/src/utils.ts
Outdated
| const webhook = new IncomingWebhook(SLACK_WEBHOOK_URL) | ||
| const text = ` :fire: _An error has occurred at_ \`${os.hostname()}\`\n \`\`\`${JSON.stringify( | ||
| error | ||
| error[1] |
There was a problem hiding this comment.
@joseph-bisonai What is stored in the first field of error?
There was a problem hiding this comment.
From this PR, you started treating it differently than before so I am curious. It could be a bit better to define the value somewhere in advance because it is reused at many places. E.g.:
const e = error[1]There was a problem hiding this comment.
Since the logger is changed to PINO, an error message differs from the previous error message. PINO logger has another array at index [0], which is unnecessary.
So I decided to bring only Index[1] contents.
For reusing the value defining a value is okay. I will change it.~
There was a problem hiding this comment.
Great! Thank you for the explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slack alarm call with unlimited time of interval issue.
Fixes # (issue)
This adds a feature of interval 1 min to send slack alarm notifications.
If the error message is different, it sends without an interval period.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment