Add accType attribute for Accounts

[KelvinThai]

Description

This PR add, AccType attribute for AccountID
Fixes # (issue)

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.

Deployment

• Should publish the npm package

[martinkersner]

@KelvinThai Thank you for digging in to the problem! I also thought about this. I will try to explain it and let me know what you think.

We could create an extra mapping to store registered coordinators instead of looping through all coordinators which punishes regular accounts creators by increasing gas cost for them.

mapping(address => bool) private sIsCoordinator;

The values of sIsCoordinator will be updated inside of addCoordinator and removeCoordinator.

The createAccount function will then look similar to the one below.

function createAccount() external returns (uint64) {
    s_currentAccId++;
    uint64 currentAccId = s_currentAccId;
    address[] memory consumers = new address[](0);
    string memory accType = "reg";
    if (sIsCoordinator[msg.sender]) {
        accType = "tmp";
    }
    s_accounts[currentAccId] = Account({balance: 0, reqCount: 0, accType: accType});
    s_accountConfigs[currentAccId] = AccountConfig({
        owner: msg.sender,
        requestedOwner: address(0),
        consumers: consumers
    });

    emit AccountCreated(currentAccId, msg.sender, accType);
    return currentAccId;
}

[KelvinThai]

Totally agreed. A mapping would give faster and cheaper access to Coordinators. Let's move this way

[martinkersner]

@KelvinThai LGTM! I added just one small suggestion, but it is ready to be merged!

[martinkersner]

Since we introduced the mapping which holds all active coordinators, we can simplify this function a lot. It could look as in the listing below.

function addCoordinator(address coordinator) public onlyOwner {
    if (sIsCoordinators[coordinator]) {
        revert CoordinatorExists();
    }
    s_coordinators.push(CoordinatorBaseInterface(coordinator));
    sIsCoordinators[coordinator] = true;
}

[martinkersner]

LGTM!