Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setting core concurrency #526

Merged
merged 10 commits into from
Apr 21, 2023
Merged

setting core concurrency #526

merged 10 commits into from
Apr 21, 2023

Conversation

jo-bisonai
Copy link
Member

@jo-bisonai jo-bisonai commented Apr 14, 2023 •
edited
Loading

Description

Waiting Queue need to work together.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@jo-bisonai jo-bisonai self-assigned this Apr 14, 2023
@jo-bisonai jo-bisonai linked an issue Apr 14, 2023 that may be closed by this pull request
VRF Redis setting #525
Closed
@jo-bisonai jo-bisonai marked this pull request as draft April 15, 2023 01:56
@jo-bisonai jo-bisonai marked this pull request as ready for review April 20, 2023 06:56
martinkersner
martinkersner approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But we will have to cleanup this PR a bit, there are quite many irrelevant files.

.github/workflows/core.image+upload.yaml Outdated Show resolved Hide resolved
.DS_Store Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it~!

cli/package-lock.json Show resolved Hide resolved
yarn-error.log Outdated
@@ -0,0 +1,37 @@
Arguments:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not push these files to the repository :)

yarn.lock Outdated Show resolved Hide resolved
@jo-bisonai jo-bisonai merged commit 3a48741 into master Apr 21, 2023
@jo-bisonai jo-bisonai deleted the i-525/vrf-redis-setting branch April 21, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinkersner martinkersner martinkersner approved these changes

Assignees

@jo-bisonai jo-bisonai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VRF Redis setting
2 participants
@jo-bisonai @martinkersner