Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregator & AggregatorProxy on-chain test #552

Merged
merged 23 commits into from
Apr 24, 2023
Merged

Aggregator & AggregatorProxy on-chain test #552

merged 23 commits into from
Apr 24, 2023

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Apr 23, 2023 •
edited
Loading

Description

This PR updates Aggregator and AggregatorProxy smart contracts and defines on-chain tests.

Coverage

  • Aggregator 84.94% statements
  • AggregatorProxy 100% statements

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this Apr 23, 2023
@martinkersner
chore: Refactor old aggregator test
e256e57
@martinkersner
test: Read from DataFeedConsumerMock
6ff5401
@martinkersner
test: Read decimals from DataFeedConsumerMock
a89ad09
@martinkersner
fix: Remove s_ in AggregatorProxy
a79cd23
@martinkersner
fix: Remove some of solhint warnings
dfc2a09
@martinkersner
feat: Propose & Confirm Aggregator Test
15d0a85
@martinkersner
feat: Read values from proposed aggregator
777432b
@martinkersner
feat: Test data from proxy specified by roundID
ddaed83
@martinkersner
feat: Test read the latest round data from aggregator with roundId
9f3e7e2
@martinkersner
feat: Test for aggregator proxy phaseId
b1e8722
@martinkersner
feat: Test for phaseAggregators
023b8fb
@martinkersner
feat: Test read configuration of Aggregator & AggregatorProxy
fde5f2d
@martinkersner
fix: Add missing interface
a386203
@martinkersner
fix: Add missing aggregator configuration
bf3b8f2
@martinkersner
feat: Test remove oracle
13d988b
@martinkersner
feat: set validateDataResponse as view function
c3cf04f
@martinkersner
feat: Test for addding oracle assetions
be06bbf
@martinkersner
feat: Remove rewards and admins from Aggregator
7eebc1b
@martinkersner
feat: Test oracleRoundState
1b3e8fd
@martinkersner
feat: Test external requester
cb18399
@martinkersner
feat: Test OracleNotEnabled
d153573
@martinkersner martinkersner linked an issue Apr 24, 2023 that may be closed by this pull request
Aggregator & AggregatorProxy on-chain tests #551
Closed
@martinkersner martinkersner marked this pull request as ready for review April 24, 2023 04:55
@martinkersner martinkersner merged commit 5ceaffa into master Apr 24, 2023
@martinkersner martinkersner deleted the i-551/feat/aggregator-aggregator-proxy-on-chain-test branch April 24, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayram98 bayram98 Awaiting requested review from bayram98

@KelvinThai KelvinThai Awaiting requested review from KelvinThai

Assignees

@martinkersner martinkersner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aggregator & AggregatorProxy on-chain tests
1 participant
@martinkersner