Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow to submit to Request-Response coordinator twice for the same request #562

Conversation

martinkersner
Copy link
Member

@martinkersner martinkersner commented Apr 26, 2023

Description

Recent changes to Request-Response that implemented submission by multiple oracles did not include a constraints on a single submission per oracle to a single request. This PR implements those constraints together with tests.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

@martinkersner martinkersner self-assigned this Apr 26, 2023
@martinkersner martinkersner marked this pull request as ready for review April 26, 2023 04:20
Copy link
Contributor

@bayram98 bayram98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@KelvinThai KelvinThai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinkersner martinkersner merged commit af95726 into master Apr 26, 2023
@martinkersner martinkersner deleted the i-561/feat/dont-allow-to-submit-data-twice-by-the-same-oracle branch April 26, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow to submit data twice to the by the same oracle in multi-submission requests
3 participants